Spacer block: Reduce minimum height to 5px #24342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapk
added
Needs Design Feedback
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
|
5px is better than 20 px... but as ong as all other blocks are missing padding & margin, why not setting the spacer to a min height of 1px? |
Answered here: #18906 (comment) |
|
Closing as superseded by #25528, thanks Mark for the exploration on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18906
This PR reduces the minimum height of the Spacer block to 5px instead of 20px.
There's been some feedback that a minimum height of 20px was too big and felt much like a bug. I agree it doesn't allow for the precise adjustments a user might like when building their layout. For this reason, I've created this PR to fiddle with and see if a minimum of 5px feels better. It is still selectable with the mouse albeit the click space is much smaller now. And it no longer aligns with the height of the Separator block either. But dang, I like being able to go smaller with this block! 😉
cc @designsimply
How has this been tested?
Tested locally.
Screenshots
Types of changes
Non-breaking changes.
Checklist: